Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecGroup UI bugs fixes and improvements #1483

Merged
merged 2 commits into from
Oct 1, 2023
Merged

SecGroup UI bugs fixes and improvements #1483

merged 2 commits into from
Oct 1, 2023

Conversation

nerdalert
Copy link
Member

@nerdalert nerdalert commented Oct 1, 2023 •
edited
Loading

A few highlight:

  • Pre-canned protocols such as MySQL/SSH are aliased along with regular rules such as tcp are defined as aliases in the SecGroup structure file to make the code more manageable.
  • Combined the pre-defined IP range and the User defined IP range and also populate based on the user typing if there is a match in the predefined rules list. Otherwise it is a new element in the field.
  • Added a tooltip to explain the user needs to hit enter after added a rule. That is a limitation of freeSolo with React AutoComplete as far as I can tell but its good for meow. Additional tooltip icons added as well.
  • Tasks tracked in UI taks and enhancement requests #1477

@nerdalert
SecGroup UI bugs fixes and improvements
6370500 
A few highlight:
- Pre-canned protocols such as MySQL/SSH are aliased along with regular
  rules such as tcp are defined as aliases in the SecGroup structure file
  to make the code more manageable.
- Combined the pre-defined IP range and the User defined IP range and also
  populate based on the user typing if there is a match in the predefined
  rules list. Otherwise it is a new element in the field.
- Added a tooltip to explain the user needs to hit enter after added a rule.
  That is a limitation of freeSolo with React AutoComplete as far as I can
  tell but its good for meow. Additional tooltip icons added as well.

Signed-off-by: Brent Salisbury <[email protected]>
@netlify
Copy link

netlify bot commented Oct 1, 2023 •
edited
Loading

✅ Deploy Preview for nexodus-docs canceled.

Name Link
🔨 Latest commit 7705762
🔍 Latest deploy log https://app.netlify.com/sites/nexodus-docs/deploys/65191ac8466dad000729ed7f

@mergify mergify bot added missing-docs-label missing has-docs or no-docs-needed missing-design-label missing has-design or no-design-needed label missing-tests-label This PR is missing a tests label, has-tests or no-tests-required labels Oct 1, 2023
@nerdalert nerdalert added no-design-required This PR does not require a design document no-docs-required This PR does not require user facing docs. no-tests-required PR does not require new test coverage and removed missing-docs-label missing has-docs or no-docs-needed missing-design-label missing has-design or no-design-needed label missing-tests-label This PR is missing a tests label, has-tests or no-tests-required labels Oct 1, 2023
@mergify mergify bot merged commit d93fd69 into nexodus-io:main Oct 1, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellb russellb russellb approved these changes

Assignees
No one assigned
Labels
no-design-required This PR does not require a design document no-docs-required This PR does not require user facing docs. no-tests-required PR does not require new test coverage
Projects
Nexodus Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nerdalert @russellb